<html>
<head><meta charset="utf-8"><title>building rustc-perf benchmarks · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html">building rustc-perf benchmarks</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="235997928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/235997928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#235997928">(Apr 24 2021 at 19:23)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I was trying to test-build the rustc-perf benchmarks locally, but the stylo one doesn't seem to build (unrelated to my <code>const_fn</code> changes)?</p>
<div class="codehilite"><pre><span></span><code>error[E0503]: cannot use `state` because it was mutably borrowed
    --&gt; /home/r/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.14/src/lib.rs:1008:33
     |
955  |     let mut machine = |cont: &amp;mut bool, (i, c): (usize, char)| {
     |                       ---------------------------------------- borrow of `state` occurs here
...
959  |         state = match (state, whitespace, limit) {
     |                        ----- borrow occurs due to use of `state` in closure
...
1008 |     while cont &amp;&amp; match state { B | C =&gt; true, A =&gt; false } {
     |                                 ^ use of borrowed `state`
1009 |         machine(&amp;mut cont, (fake_i, &#39; &#39;));
     |         ------- borrow later used here
</code></pre></div>
<p>This is when doing <code>cargo +nightly build</code> in the <code>collector/benchmarks/style-servo</code> directory.</p>



<a name="235998228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/235998228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#235998228">(Apr 24 2021 at 19:27)</a>:</h4>
<p>That's a problem since it means I cannot test if the use of the <code>const_fn</code> feature in that crate is still required or can be removed.^^</p>



<a name="235999440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/235999440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#235999440">(Apr 24 2021 at 19:43)</a>:</h4>
<p>Hm I don't think that's the right invocation</p>



<a name="235999445"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/235999445" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#235999445">(Apr 24 2021 at 19:43)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> look at perf-config.json</p>



<a name="235999499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/235999499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#235999499">(Apr 24 2021 at 19:44)</a>:</h4>
<p>Probably some --manifest-path needs to be passed</p>



<a name="236007579"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/236007579" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#236007579">(Apr 24 2021 at 21:13)</a>:</h4>
<p>ah, got it, thanks :)<br>
the right working dir is <code>collector/benchmarks/style-servo/components/style</code>, and I added <code>--features gecko</code></p>



<a name="236007604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/236007604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#236007604">(Apr 24 2021 at 21:13)</a>:</h4>
<p>now it seems to build (with dozens of deprecation warnings...)</p>



<a name="236008506"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/236008506" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#236008506">(Apr 24 2021 at 21:25)</a>:</h4>
<p>aiui the benchmarks are snapshots of old code so they don't change, so that wouldn't be unexpected</p>



<a name="236078130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/building%20rustc-perf%20benchmarks/near/236078130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/building.20rustc-perf.20benchmarks.html#236078130">(Apr 25 2021 at 16:49)</a>:</h4>
<p><span class="user-mention silent" data-user-id="330154">The 8472</span> <a href="#narrow/stream/122651-general/topic/building.20rustc-perf.20benchmarks/near/236008506">said</a>:</p>
<blockquote>
<p>aiui the benchmarks are snapshots of old code so they don't change, so that wouldn't be unexpected</p>
</blockquote>
<p>yeah I had to bump a git SHA somewhere</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>